-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Rework playlist progressbar #1226
base: master
Are you sure you want to change the base?
Conversation
98af675
to
236d4c7
Compare
Use UIView and background colors instead of UIImages. The progressbar itself is a child view of a masking UIView. Correct the layout to have the whole progress view aligning with the cell's bottom. Remove all images which are not required anymore.
The animation is only shown when the progressbar is updated from width of 0 (= start value) to any non-zero value. Effectively, the animation is only done the first time a playlist is loaded during an already advanced playback. The xib starts with progress = 11 to visualize the progress bar's function in the xib.
236d4c7
to
1e7629d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use UIProgressBar
Oh no. I wasn't even aware this exists ... |
i played around with Does not have any effect using
|
try setting |
Doesn't make any difference. |
ok, then let's forget about UIProgressView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now you should use your new progress bar component
I guess I shot myself in the foot now. The class I introduced in #1220 is not a generic progress bar, but already tailored for PVR/broadcast (I even should rename the class to reflect this). Here, I need a generic one which only does the progress bar itself. This could then be used in the PVR/broadcast and the playlist progress view. Separate PR to unify this later? Otherwise I would introduce the progress bar view class here, and then rebase/adapt the LiveTV PR to make use if it. |
performing refactoring right in #1220 would fine as well |
Description
Use
UIView
and theirbackgroundColor
instead ofUIImages
. The progress bar itself is a child view of a maskingUIView
. The layout is corrected to have the whole progress view aligning withcell's
bottom. The animation from 0-to-x% was updated to finish well within the update cycle time of 1 second and to only run, if the progress bar is updated first time for an already advanced playback. All now obsolete images are removed.Screenshots (left = before, right = after):
Summary for release notes
Improvement: Rework playlist progressbar