Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint 4.0 #2288

Closed
wants to merge 7 commits into from
Closed

Blueprint 4.0 #2288

wants to merge 7 commits into from

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented Feb 12, 2021

[This was originally Colin's Branch to update to Popover2.0. Now its a full update to Blueprint 4.0.]

Known Styling issues that need to be addressed by a css expert:

  • Dark Mode issues (should be immediately obvious)
  • Dialog margins missing (see e.g. options Dialog, and various built-in prompts)

Known Code issues that are in progress:

  • ContextMenus Broken
  • Grouping Chooser drag rendering is very weird

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

# Conflicts:
#	desktop/cmp/input/DateInput.js
#	kit/blueprint/index.js
#	package.json
#	yarn.lock
@lbwexler lbwexler changed the title Integrate changes required by BP's popover2 lib. Blueprint 4.0 May 5, 2021
@lbwexler lbwexler self-assigned this May 6, 2021
@lbwexler lbwexler requested a review from TomTirapani May 6, 2021 23:48
@lbwexler lbwexler linked an issue May 7, 2021 that may be closed by this pull request
@amcclain
Copy link
Member

They released their first 4.0 build three days ago...

https://github.com/palantir/blueprint/wiki/Blueprint-4.0

@lbwexler
Copy link
Member

What a relief -- not looking forward to this transitional work, but also was a little worried that all was not well in the land of blueprintjs

@lbwexler
Copy link
Member

closing this in favor of a new branch that leaves out the BP API changes that were deferred until 5.x

@lbwexler lbwexler closed this Jun 22, 2022
@lbwexler lbwexler deleted the popover2 branch March 8, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Menu component(s) - replaces direct use of Blueprint
3 participants