Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X.A.WindowBringer: Add copyMenu #895

Merged
merged 2 commits into from
Jun 16, 2024
Merged

X.A.WindowBringer: Add copyMenu #895

merged 2 commits into from
Jun 16, 2024

Conversation

thalting
Copy link
Contributor

@thalting thalting commented Jun 16, 2024

XMonad.Prompt.WindowBringer (copyMenu)

A convenient way to copy a window to the current workspace.

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: XXX

  • I updated the CHANGES.md file

@geekosaur
Copy link
Contributor

Looks like you forgot to include your changes to xmonad-contrib.cabal?

@thalting
Copy link
Contributor Author

Looks like you forgot to include your changes to xmonad-contrib.cabal?

What changes? Wouldn't that be for new modules?

@geekosaur
Copy link
Contributor

Oh, I see, you don't run the test suite. The problem is that the test suite tests XMonad.Actions.WindowBringer, so its new dependencies need to be added to its other-modules.

@geekosaur
Copy link
Contributor

Okay, that looks better. Although now that I look, I don't see the test suite actually using WindowBringer at all, so possibly it needs to be removed (not your problem, it's future work and I'll have to check for any other dependencies the test suite isn't using).

@geekosaur geekosaur merged commit bbbf5c3 into xmonad:master Jun 16, 2024
20 checks passed
@geekosaur
Copy link
Contributor

Thanks!

@geekosaur
Copy link
Contributor

Looks like something is using it after all…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants