continue fix bugs related to electron env function

xuyao197290508 · Dec 28, 2020 · 32e8888 · 32e8888
1 parent 0ef8521
commit 32e8888
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/js/app.js b/js/app.js
@@ -1702,7 +1702,7 @@ const main = () => {
       },
       link(scope, element, attrs) {
         element.bind('click', (event) => {
-          if ((typeof chrome) === 'undefined') {
+          if (isElectron()) {
             var shell = require('electron').shell;
             shell.openExternal(scope.url);
           }

diff --git a/js/github.js b/js/github.js
@@ -5,7 +5,7 @@ ngGithub.factory('github', ['$rootScope',
   $rootScope => ({
     openAuthUrl: () => {
       const url = Github.getOAuthUrl();
-      if ((typeof chrome) === 'undefined') {
+      if (isElectron()) {
         // normal window for link
         const { BrowserWindow } = require('electron').remote; // eslint-disable-line import/no-unresolved
         let win = new BrowserWindow({