XWIKI-22798: The code macro is missing a required rights analyzer

[michitux]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22798

Changes

Description

• Add a required rights analyzer for the code macro.
• Add a test.

Clarifications

• The bean manager is used to initialize the parameters to make sure that the behavior is exactly as in the actual macro execution.
• I don't think other sources should require any special rights.

Screenshots & Video

Executed Tests

LANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,quality -pl :xwiki-platform-rendering-macro-code                       

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • stable-16.4.x
  • stable-16.10.x
  • stable-17.0.x

[tmortagne]

Don't you want to also cover context and content source parameter too ? Or maybe you are planning to do that in separate issues already ?

Actually, I'm wondering if we should have something more generic, which is checking all macro parameters descriptors for the type MacroContentSourceReference (instead of having to add a new MacroRequiredRightsAnalyzer for each macro which used this type of parameters). It's true that some macro might decide to ignore script type parameters, but I guess it's unlikely.

[michitux]

Actually, I'm wondering if we should have something more generic, which is checking all macro parameters descriptors for the type MacroContentSourceReference (instead of having to add a new MacroRequiredRightsAnalyzer for each macro which used this type of parameters). It's true that some macro might decide to ignore script type parameters, but I guess it's unlikely.

The problem is that the impact of those parameters is quite different depending on the macro. For the code macro, the content of the script doesn't matter. For the context and content macro, it depends, and I think we also need to warn about the rights that the script variable's content requires. However, this is again not true for the context macro if the restricted parameter is true. And for both of them, we also need to analyze wiki content in the string source while this is not necessary for the code macro. Therefore, I'm not so sure how much we would gain with a central analyzer.

[tmortagne]

My point was more that this macro parameter type is generic enough to be matched as something that makes the macro require script right (if using the script type), no so much as "a generic check is enough to cover all use cases". Maybe that generic check of that parameter type should be in some default macro analyzer which is used only if no specific analyzer was found for the given macro (did no check if we have the concept of default analyzer currently but I vaguely remember something like this) ? I just feel that it's very easy for a new macro to forget to provide an analyzer, and I'm petty sure this will happen all the time.

[tmortagne]

In any case, it looks OK for the code macro.