ci(feed): CIで画像のキャッシュを毎回更新する #205
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request focuses on enhancing the GitHub Actions workflow configurations for CI and feed generation. The primary modifications involve implementing caching mechanisms for feed images across two workflow files: Changes
Possibly related PRs
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
.github/workflows/generate-feed.yml (2)
37-46: Consider optimizing cache restore configuration.The cache restore implementation looks good, but could benefit from some optimizations:
- Add compression for image caching:
- name: Restore feed images cache uses: actions/cache/restore@v4 with: path: | .cache public/images/feed-thumbnails public/images/feed-icons key: ${{ runner.os }}-feed-images-${{ hashFiles('src/resources/feed-info-list.ts') }} restore-keys: | ${{ runner.os }}-feed-images- + enableCrossOsArchive: true + compression-level: 6
53-60: Add cache monitoring.The cache save implementation is correct, but adding monitoring would help track cache effectiveness:
- name: Save feed images cache uses: actions/cache/save@v4 with: path: | .cache public/images/feed-thumbnails public/images/feed-icons key: ${{ runner.os }}-feed-images-${{ hashFiles('src/resources/feed-info-list.ts') }} + id: cache-feed-images + - name: Check cache status + if: always() + run: | + echo "Cache hit: ${{ steps.cache-feed-images.outputs.cache-hit }}" + echo "Cache matched key: ${{ steps.cache-feed-images.outputs.cache-matched-key }}".github/workflows/ci.yml (2)
102-111: Consider implementing a reusable workflow for caching logic.The cache implementation is duplicated between workflows. Consider creating a reusable workflow:
- Create a new file
.github/workflows/cache-feed-images.yml:name: Cache Feed Images on: workflow_call: outputs: cache-hit: description: "Whether there was a cache hit" value: ${{ jobs.cache-images.outputs.cache-hit }} jobs: cache-images: runs-on: ubuntu-latest outputs: cache-hit: ${{ steps.cache-feed-images.outputs.cache-hit }} steps: - name: Restore feed images cache id: cache-feed-images uses: actions/cache/restore@v4 with: path: | .cache public/images/feed-thumbnails public/images/feed-icons key: ${{ runner.os }}-feed-images-${{ hashFiles('src/resources/feed-info-list.ts') }} restore-keys: | ${{ runner.os }}-feed-images-Then use it in both workflows:
jobs: cache: uses: ./.github/workflows/cache-feed-images.yml
118-125: Optimize CI cache configuration.The cache save configuration in CI could benefit from CI-specific optimizations:
- name: Save feed images cache uses: actions/cache/save@v4 with: path: | .cache public/images/feed-thumbnails public/images/feed-icons key: ${{ runner.os }}-feed-images-${{ hashFiles('src/resources/feed-info-list.ts') }} + enableCrossOsArchive: true + compression-level: 6 + if: github.event_name == 'pull_request'This ensures we only save cache in PR builds to avoid cache pollution from feature branches.
yamadashy
force-pushed
the
feature/ci-cache
branch
from
fe53e77 to
b31c1c4
Compare
No description provided.