Fix path inconsistencies #34
Conversation
FixtureController.php
Outdated
| /** | ||
| * @var string Alias to the fixture data path, where data files should be written. | ||
| */ | ||
| public $fixtureDataPath = '@tests/unit/fixtures/data'; | ||
| public $fixtureDataPath = '@tests/fixtures/data'; |
There was a problem hiding this comment.
this would be breaking BC, can we fix overall consistency without BC break? And change the Paths in version 2.1 to be independent from unit tests then.
There was a problem hiding this comment.
We could hardcode the former fixtureDataPath value into the config/console.php configuration file of the yii2-app-basic template:
Like this:
'controllerMap' => [
'fixture' => [ // Fixture generation command line.
'class' => 'yii\faker\FixtureController',
'fixtureDataPath' => '@tests/unit/fixtures/data',
],
],
There was a problem hiding this comment.
@ricpelo won't help since app templates are never updated in existing projects.
There was a problem hiding this comment.
@samdark You're right. Maybe we could do it for Yii 2.1?
There was a problem hiding this comment.
We can release 2.1 version of the extension and note that it has backwards incompatibilities.
There was a problem hiding this comment.
@samdark May I need to create another PR, this time against 2.1 branch?
|
@samdark I've just updated the PR so it's now against |
Fixes #33.