Skip to content

Commit

Permalink
The 16 byte case here can't possibly be correct in general.
Browse files Browse the repository at this point in the history
I'm not sure why we ever ended up with this: I don't see anything that
triggers it. If there is something that relies on it, it surely only
works by accident, and we're better hitting the `todo` and then fixing
this properly.
  • Loading branch information
ltratt committed Jan 10, 2025
1 parent 07c3cae commit 958c432
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ykrt/src/compile/jitc_yk/codegen/x64/deopt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ pub(crate) extern "C" fn __yk_deopt(
};
match size {
// FIXME: Check that 16-byte writes are for float registers only.
16 | 8 => unsafe { ptr::write::<u64>(temp as *mut u64, jitval) },
8 => unsafe { ptr::write::<u64>(temp as *mut u64, jitval) },
4 => unsafe { ptr::write::<u32>(temp as *mut u32, jitval as u32) },
2 => unsafe { ptr::write::<u16>(temp as *mut u16, jitval as u16) },
_ => todo!("{}", size),
Expand Down

0 comments on commit 958c432

Please sign in to comment.