Turn hard errors in trace decoding into a recoverable failure. #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes -- not often, but sometimes -- encounter either the `assert` or `unreachable` in the code below. This commit turns these cases into recoverable errors. Is that the right thing to do? I'm not entirely sure, and welcome Edd's comments!
|
Ideally we'd investigate and figure out why this happens, but perhaps we have bigger fish to fry? |
This is your parish, so you decide. |
|
Since a) it prints an error to let us know this happened, and b) we are not sure if we will keep hardware tracing, I opt to move on for now. |
|
(if you mark it ready, i will merge) |
|
Marked as ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes -- not often, but sometimes -- encounter either the
assertorunreachablein the code below. This commit turns these cases into recoverable errors. Is that the right thing to do? I'm not entirely sure, and welcome Edd's comments!