Teach the reverse analyser about calls #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Just a clippy error it seems. |
This is enough for FP hints to be at least somewhat useful: without this, they don't have any effect. There is more we can port over from the GP allocator, but I'd like to think about the bigger picture at another point.
|
Oops! Force pushed a Clippy fix. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
One of the nondeterministic bugs bit us. Let's try again. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I can't replicate this on b16 after |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main commit ensures that operands tend to end up in the right register for calls; the second commit is the bare minimum necessary to take advantage of this for FP arguments.