Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 16 byte case here can't possibly be correct in general. #1541

Merged
merged 1 commit into from
Jan 13, 2025
Merged

The 16 byte case here can't possibly be correct in general. #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ykrt/src/compile/jitc_yk/codegen/x64/deopt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,7 @@ pub(crate) extern "C" fn __yk_deopt(
unsafe { rbp.offset(isize::from(*extra)) }
};
match size {
// FIXME: Check that 16-byte writes are for float registers only.
16 | 8 => unsafe { ptr::write::<u64>(temp as *mut u64, jitval) },
8 => unsafe { ptr::write::<u64>(temp as *mut u64, jitval) },
4 => unsafe { ptr::write::<u32>(temp as *mut u32, jitval as u32) },
2 => unsafe { ptr::write::<u16>(temp as *mut u16, jitval as u16) },
_ => todo!("{}", size),
Expand Down
Loading