Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

OP-6382 - Thumbnail Integration Problem #6156

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,11 @@ def _create_review_representation(
instance.data["thumbnailSource"] = first_filepath

review_representation["tags"].append("review")

# Adding "review" to representation name since it can clash with main
# representation if they share the same extension.
review_representation["outputName"] = "review"

self.log.debug("Representation {} was marked for review. {}".format(
review_representation["name"], review_path
))
Expand Down
7 changes: 7 additions & 0 deletions openpype/plugins/publish/extract_color_transcode.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,13 @@ def process(self, instance):
if len(new_repre["files"]) == 1:
new_repre["files"] = new_repre["files"][0]

# If the source representation has "review" tag, but its not
# part of the output defintion tags, then both the
# representations will be transcoded in ExtractReview and
# their outputs will clash in integration.
if "review" in repre.get("tags", []):
added_review = True

new_representations.append(new_repre)
added_representations = True

Expand Down
5 changes: 4 additions & 1 deletion openpype/plugins/publish/extract_thumbnail.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,10 @@ def _main_process(self, instance):
"files": jpeg_file,
"stagingDir": dst_staging,
"thumbnail": True,
"tags": new_repre_tags
"tags": new_repre_tags,
# If source image is jpg then there can be clash when
# integrating to making the output name explicit.
"outputName": "thumbnail"
}

# adding representation
Expand Down
Loading