This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
Denotes a PR changes 0-99 lines, ignoring general files
type: bug
Something isn't working
labels
Jan 26, 2024
Might be worth having a checklist of DCCs to tick off as we test them. |
Task linked: OP-7725 Substance - Workfile UI under the main UI |
Unrelated to this PR.
Unrelated to PR, @kalisp please contact @LiborBatek and take a look. |
@MustafaJafar maybe could u help with testing too (Houdini and maybe more) ? |
MustafaJafar
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Houdini. It worked fine for me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
size/XS
Denotes a PR changes 0-99 lines, ignoring general files
target: AYON
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Changing back Publisher window to QDialog.
Additional info
The reasoning for changing it to
QWidget
was to avoid having window always on top, whichQDialog
might cause on it's own (even without AlwaysOnTop flag). But it was found out that usingQWidget
withWindow
flag did break window positioning for some DCCs and broke stylesheets for almost all of them, especially when parent was passed to init. The reason why that happens was not revealed.At the same time there was random behavior in substance painter where the publisher tool was moved under substance without any user interaction, when parent was not passed in, and had broken stylesheets when parent was passed in.
This might again raise issues when a DCC opens dialog that is modal, it might show under publisher and block the process.
Testing notes: