Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: added fallback for broken ffprobe return #6189

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Feb 1, 2024

Changelog Description

Customer provided .exr returned width and height equal to 0 which caused error in extract_thumbnail. This tries to use oiiotool to get metadata about file, in our case it read it correctly.

Additional info

AnyDesk_XwH276p3SU

This PR is a bit weird as it solves very specific use case, which could be reoccurring though as source .exr comes from Deadline render from Maya and it is not supposed to be special. This update provide just one more layer of safety.

Testing notes:

  1. test on customer site OR
  2. use attached test file from Clickup issue and run this in Tray > Console:
from openpype.lib.transcoding import  get_rescaled_command_arguments

input_path = "FILE_PATH"
args = get_rescaled_command_arguments("oiiotool", input_path, 1900, 1200)
print(args )

Customer provided .exr returned width and height equal to 0 which caused error in extract_thumbnail. This tries to use oiiotool to get metadata about file, in our case it read it correctly.
`get_rescaled_command_arguments` is long enough right now, new method is better testable too.
@kalisp kalisp added the sponsored Client endorsed or requested label Feb 1, 2024
@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Feb 1, 2024
@kalisp kalisp requested a review from antirotor February 1, 2024 17:12
@kalisp kalisp merged commit ed339ed into develop Feb 5, 2024
3 checks passed
@kalisp kalisp deleted the enhancement/OP-8090_Deadline-reinstallation branch February 5, 2024 09:26
@ynbot ynbot added this to the next-patch milestone Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants