Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set resolution using the virtual resolution and set pixel aspect ratio from entity #22

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Set resolution using the virtual resolution and set pixel aspect ratio from entity #22

merged 3 commits into from
Jan 22, 2025
+21 −2

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 22, 2025

Changelog Description

Set resolution using the virtual resolution and set pixel aspect ratio from entity

Additional review information

Fix #20

Testing notes:

  1. Setting resolution should consider updating the film aspect ratio and pixel aspect ratio

@BigRoy BigRoy requested a review from MustafaJafar January 22, 2025 14:30
@BigRoy BigRoy self-assigned this Jan 22, 2025
@BigRoy BigRoy added the type: bug Something isn't working label Jan 22, 2025
@BigRoy BigRoy marked this pull request as ready for review January 22, 2025 22:26
@BigRoy BigRoy merged commit 52f39a7 into develop Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustafaJafar MustafaJafar Awaiting requested review from MustafaJafar

Assignees

@BigRoy BigRoy

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting the resolution using the AYON menu, doesn't update the aspect ratio
1 participant
@BigRoy