Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: render use existing frames with slate offsets the published render - AY-1433 #158

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Nuke: render use existing frames with slate offsets the published render - AY-1433 #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a0b236
Remove representation unnessecary frameStart
tokejepsen Mar 7, 2024
8b4085b
Exclude instances nodes from slate collection.
tokejepsen Mar 7, 2024
1d0a60e
Merge branch 'develop' into bugfix/AY-1433_Nuke-Render-Use-existing-f…
jakubjezek001 Mar 8, 2024
28661d7
Merge branch 'develop' into bugfix/AY-1433_Nuke-Render-Use-existing-f…
jakubjezek001 Mar 11, 2024
aadc465
Merge branch 'develop' into bugfix/AY-1433_Nuke-Render-Use-existing-f…
jakubjezek001 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/ayon_core/hosts/nuke/plugins/publish/collect_slate_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ def process(self, instance):
(
n_ for n_ in nuke.allNodes()
if "slate" in n_.name().lower()
if not n_["disable"].getValue()
if not n_["disable"].getValue() and
"publish_instance" not in n_.knobs() # Exclude instance nodes.
),
None
)
Expand Down
5 changes: 0 additions & 5 deletions client/ayon_core/hosts/nuke/plugins/publish/collect_writes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ def _set_additional_instance_data(
"frameEndHandle": last_frame,
})


# TODO temporarily set stagingDir as persistent for backward
# compatibility. This is mainly focused on `renders`folders which
# were previously not cleaned up (and could be used in read notes)
Expand Down Expand Up @@ -269,10 +268,6 @@ def _get_existing_frames_representation(
"tags": []
}

frame_start_str = self._get_frame_start_str(first_frame, last_frame)

representation['frameStart'] = frame_start_str

# set slate frame
collected_frames = self._add_slate_frame_to_collected_frames(
instance,
Expand Down