Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dialogs from widgets to tools/utils #3

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 7, 2024

Changelog Description

Moved Popup, PopupUpdateKeys and Window from ayon_core/widgets/ to ayon_core/tools/utils/dialogs.py.

Additional info

Replaced Window class with show_message_dialog function, as the Window was actually never showed as window. Renamed Popup to SimplePopup.

Testing notes:

  • Blender should show window if unit scale does not match (function on_open)
  • Fusion should show a dialog if scene preferences are not correct (function validate_comp_prefs)
  • Fusion should show a dialog if scene contains outdated representations (function on_after_open)
  • Houdini should show a dialog if scene contains outdated representations (function _show_outdated_content_popup)
  • Houdini should show a dialog if scene has invalid fps (function validate_fps)
  • Houdini - not sure what update_houdini_vars_context_dialog does?
  • 3dsMax should show dialog in check_colorspace
  • Maya should show a dialog if scene contains outdated representations (function on_open)
  • Maya should show a dialog if scene has invalid fps (function validate_fps)
  • SubstancePainter should show a dialog if scene contains outdated representations (function on_open)
  • Unreal Inventory action Delete Unused Assets should show confirm dialog

@simonebarbieri
Copy link
Contributor

I can confirm that Blender and Unreal show the dialog correctly

@moonyuet
Copy link
Member

moonyuet commented Feb 8, 2024

have tested in Max, the dialog doesn't show up but I dont think it is because of the dialogs itself. it is more likely because the OCIO configuration with ayon-core addon doesn't set up correctly in Max as if with Openpype addon
image

also tested in Substance Painter and Maya, the DCCs show the dialog correctly

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in Houdini.

image

image

image

@iLLiCiTiT iLLiCiTiT merged commit 8745c2c into feature/OP-8123_Addon-initialization-phase-one Feb 8, 2024
2 of 5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/move-dialogs-from-widgets branch February 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants