Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractOIIOTranscode: Log warning instead of raise error if media can't be transcoded due to unknown RGBA channels #988

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Nov 6, 2024

Changelog Description

Allow ExtractOIIOTranscode to pass with a warning if it can't find the RGBA channels in source media instead of raising error

Additional info

Over time we've had annoying reports where studios were unable to publish their renders because the publishing system (due to user configuration) tries to transcode e.g. a Z-depth AOV layer which may only have a named Z or Y channel and has no R, G, B or A channels and hence we don't really know what layer to process.

Instead of this we could also implement detecting more cases, so that if RGBA is not found in the file that maybe we allow to fall back to channels:

  • XYZ
  • Y
  • Z (usually for z-depth?)

Here's metadata output for a file that fails without this PR:

<nchannels>1</nchannels>
<channelnames>
<channelname>Y</channelname>
</channelnames>
<alpha_channel>-1</alpha_channel>
<z_channel>-1</z_channel>
<deep>0</deep>

It's an Arnold Z-depth render AOV.

Testing notes:

  1. Unknown RGBA channels will now log a warning instead of disallow publishing altogether.

@BigRoy BigRoy added the type: bug Something isn't working label Nov 6, 2024
@BigRoy BigRoy self-assigned this Nov 6, 2024
@ynbot ynbot added the size/XS label Nov 6, 2024
@BigRoy BigRoy marked this pull request as draft November 6, 2024 08:28
@BigRoy BigRoy added the community Issues and PRs coming from the community members label Nov 6, 2024
@jakubjezek001
Copy link
Member

jakubjezek001 commented Jan 13, 2025

I wonder if we always want to make the process fail gracefully if RGB channels are missing or there might be cases where this is not desired and the process should consider it hard fail. In that case we should probably have some switch for the detection. But to be frank I am not currently aware of the case we would need to have it hard fail all the time.

@iLLiCiTiT
Copy link
Member

I wonder how it ends up being marked for review if it cannot be used for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-7315_Extract Review and OIIO transcode failing to transcode media blocking publishes
4 participants