Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement callbacks to show attributes if farm is enabled #54

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Oct 29, 2024

Changelog Description

This PR implement callbacks to some plugins show attributes if farm is enabled.
I only tested it in Houdini.

Note

This PR is mainly made for sharing code and show a use case for ynput/ayon-core#994
It should be used along #49 and ynput/ayon-houdini#149
Here's what to expect when using the three PRs togther
Animation_17

Testing notes:

  1. Launch Houdini via AYON
  2. Create a cache instance (vdb, model, pointcache, ass, rsproxy)
  3. Switch farm toggle in the publisher UI, click save, click refresh and watch the attributes appear and disappear.

@MustafaJafar MustafaJafar requested a review from BigRoy November 12, 2024 16:58
@moonyuet
Copy link
Member

moonyuet commented Nov 13, 2024

Sorry for the duplicated comment.
I did a simple test with the callback but it seems that it does not apply the change as the changelog description depicts. Is it expected behavior?

houdini_callback.mp4

@MustafaJafar
Copy link
Contributor Author

This PR is wrong.
the callbacks should be implemented on the CollectJobInfo plugin. (this is a new plugin implemented in #49 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants