Do not set environment env variables from ayon-core #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
added
the
type: enhancement
MilaKudr
approved these changes
Jan 7, 2025
iLLiCiTiT
added
community
iLLiCiTiT
deleted the
enhancement/93-do-not-set-environment-core-variables
branch
|
Kistu login |
You should, matching this change, update |
|
I've removed kitsu environment variables passing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use constant
FARM_JOB_ENV_DATA_KEYfrom ayon-core instead ofJOB_ENV_DATA_KEY. And do not fill environment variables that are filled by ayon-core already.Additional review information
One step closer to avoid setting up environment variables that have nothing to do with deadline. Validate that all removed environment variables are already set by ayon-core.
Marked code in
lib.pythat is pipeline related and probably should not be there as the file is imported byaddon.py.Testing notes: