change .bat to .cmd for Houdini 20 and higher #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Jan 15, 2025
Comment on lines
+25
to
+27
| houdiniVersion = os.environ["HOUDINI_VERSION"] | ||
| major = int(houdiniVersion.split(".")[0]) | ||
| if major >= 20: |
There was a problem hiding this comment.
I think we're better of querying this from Houdini directly.
Suggested change
| houdiniVersion = os.environ["HOUDINI_VERSION"] | |
| major = int(houdiniVersion.split(".")[0]) | |
| if major >= 20: | |
| if hou.applicationVersion()[0] >= 20: |
Do note that you'd need to add import hou too.
|
Hello, for sake of getting this merged, I've included your commit (which keeps your contribution), added one more and creating a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR changes the usdview executable file extension name from ".bat" to ".cmd" for Houdini 20 and higher.
This fixes the show in usdview button in the houdini loader for Houdini 20.
Additional review information
Added Houdini version check that switches between the file extensions
Testing notes: