Replace render path in write nodes from stagingDir #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stagingDir could use dynamic path, using {version} or some unique descriptor. Render path of write nodes used this path only during creation, this updates each publish run.
|
This is only replacing/updating values in path as `...vXXXX...` to `...vXXXX+1...`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Custom
stagingDir(ayon+settings://core/tools/publish/custom_staging_dir_profiles) could use dynamic portion, using {version} or some unique descriptor. Render path of write nodes sets thisstagingDirpath only during creation time (eg. it stays static), this updates each publish run.Additional review information
WIP
Use case for this would be to sending multiple jobs do Deadline with suspended Publish job. Artist then will visually check all rendered images and enable only appropriate
Publishjob.Issue is how to build unique portion of path,
{version}doesn't work as it points to published version of product. Time component (like{ddmmyyyy}) doesn't seem to work.Another issue is if path in write nodes should be refreshed all the time, or it should be configurable in Settings (and by default disabled). (Problem there is that one needs to remember prepare custom staging dir template AND enable it in
CollectNukeWrites)Testing notes:
resolves #55