Add some more goldenfile tests

aws/fake/cf.go

@@ -17,22 +17,28 @@ type CFOutputs struct {
 
 type CFClient struct {
 	cloudformationiface.CloudFormationAPI
-	lastStackTemplate string
-	lastStackParams   []*cloudformation.Parameter
-	lastStackTags     []*cloudformation.Tag
-	Outputs           CFOutputs
+	templateCreationHistory []string
+	paramCreationHistory    [][]*cloudformation.Parameter
+	tagCreationHistory      [][]*cloudformation.Tag
+	Outputs                 CFOutputs
 }
 
-func (m *CFClient) GetLastStackTemplate() string {
-	return m.lastStackTemplate
+func (m *CFClient) GetTemplateCreationHistory() []string {
+	return m.templateCreationHistory
 }
 
-func (m *CFClient) GetLastStackParams() []*cloudformation.Parameter {
-	return m.lastStackParams
+func (m *CFClient) GetParamCreationHistory() [][]*cloudformation.Parameter {
+	return m.paramCreationHistory
 }
 
-func (m *CFClient) GetLastStackTags() []*cloudformation.Tag {
-	return m.lastStackTags
+func (m *CFClient) GetTagCreationHistory() [][]*cloudformation.Tag {
+	return m.tagCreationHistory
+}
+
+func (m *CFClient) CleanCreationHistory() {
+	m.paramCreationHistory = [][]*cloudformation.Parameter{}
+	m.tagCreationHistory = [][]*cloudformation.Tag{}
+	m.templateCreationHistory = []string{}
 }
 
 func (m *CFClient) DescribeStacksPages(in *cloudformation.DescribeStacksInput, fn func(*cloudformation.DescribeStacksOutput, bool) bool) (err error) {
@@ -62,9 +68,9 @@ func (m *CFClient) DescribeStacks(in *cloudformation.DescribeStacksInput) (*clou
 }
 
 func (m *CFClient) CreateStack(params *cloudformation.CreateStackInput) (*cloudformation.CreateStackOutput, error) {
-	m.lastStackTags = params.Tags
-	m.lastStackParams = params.Parameters
-	m.lastStackTemplate = *params.TemplateBody
+	m.tagCreationHistory = append(m.tagCreationHistory, params.Tags)
+	m.paramCreationHistory = append(m.paramCreationHistory, params.Parameters)
+	m.templateCreationHistory = append(m.templateCreationHistory, *params.TemplateBody)
 
 	out, ok := m.Outputs.CreateStack.response.(*cloudformation.CreateStackOutput)
 	if !ok {
@@ -80,9 +86,8 @@ func MockCSOutput(stackId string) *cloudformation.CreateStackOutput {
 }
 
 func (m *CFClient) UpdateStack(params *cloudformation.UpdateStackInput) (*cloudformation.UpdateStackOutput, error) {
-	m.lastStackTags = params.Tags
-	m.lastStackParams = params.Parameters
-	m.lastStackTemplate = *params.TemplateBody
+	// TODO: Update stack needs another logic to register state update, so createStack and updateStack don't
+	// mess with each other states.
 
 	out, ok := m.Outputs.UpdateStack.response.(*cloudformation.UpdateStackOutput)
 	if !ok {

testdata/simple_nlb/ing.yaml → testdata/ingress_nlb/input/k8s/ing.yaml

@@ -15,4 +15,4 @@ spec:
             port:
               name: main-port
         path: /
-        pathType: ImplementationSpecific
+        pathType: ImplementationSpecific

testdata/ingress_rg_notshared_alb/input/k8s/01-ing.yaml

@@ -0,0 +1,16 @@
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: myingress
+spec:
+  rules:
+  - host: foo.bar.org
+    http:
+      paths:
+      - backend:
+          service:
+            name: foo-bar-service
+            port:
+              name: main-port
+        path: /
+        pathType: ImplementationSpecific

testdata/ingress_rg_notshared_alb/input/k8s/02-rg.yaml

@@ -0,0 +1,18 @@
+apiVersion: zalando.org/v1
+kind: RouteGroup
+metadata:
+  name: my-route-group
+  annotations:
+    zalando.org/aws-load-balancer-shared: "false"
+spec:
+  hosts:
+    - foo.bar.org
+  backends:
+  - name: my-backend
+    type: service
+    serviceName: my-service
+    servicePort: 80
+  routes:
+    - pathSubtree: /
+      backends:
+        - backendName: my-backend

testdata/ingress_rg_notshared_alb/output/params/01-ing.json

@@ -0,0 +1,54 @@
+[
+  {
+    "parameterKey": "LoadBalancerSchemeParameter",
+    "parameterValue": "internet-facing"
+  },
+  {
+    "parameterKey": "LoadBalancerSecurityGroupParameter",
+    "parameterValue": "42"
+  },
+  {
+    "parameterKey": "LoadBalancerSubnetsParameter",
+    "parameterValue": "foo1"
+  },
+  {
+    "parameterKey": "TargetGroupVPCIDParameter",
+    "parameterValue": "1"
+  },
+  {
+    "parameterKey": "TargetGroupTargetPortParameter",
+    "parameterValue": "0"
+  },
+  {
+    "parameterKey": "ListenerSslPolicyParameter",
+    "parameterValue": "ELBSecurityPolicy-2016-08"
+  },
+  {
+    "parameterKey": "IpAddressType",
+    "parameterValue": "ipv4"
+  },
+  {
+    "parameterKey": "Type",
+    "parameterValue": "application"
+  },
+  {
+    "parameterKey": "HTTP2",
+    "parameterValue": "true"
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckPathParameter",
+    "parameterValue": ""
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckPortParameter",
+    "parameterValue": "0"
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckIntervalParameter",
+    "parameterValue": "0"
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckTimeoutParameter",
+    "parameterValue": "0"
+  }
+]

testdata/ingress_rg_notshared_alb/output/params/02-rg.json

@@ -0,0 +1,54 @@
+[
+  {
+    "parameterKey": "LoadBalancerSchemeParameter",
+    "parameterValue": "internet-facing"
+  },
+  {
+    "parameterKey": "LoadBalancerSecurityGroupParameter",
+    "parameterValue": "42"
+  },
+  {
+    "parameterKey": "LoadBalancerSubnetsParameter",
+    "parameterValue": "foo1"
+  },
+  {
+    "parameterKey": "TargetGroupVPCIDParameter",
+    "parameterValue": "1"
+  },
+  {
+    "parameterKey": "TargetGroupTargetPortParameter",
+    "parameterValue": "0"
+  },
+  {
+    "parameterKey": "ListenerSslPolicyParameter",
+    "parameterValue": "ELBSecurityPolicy-2016-08"
+  },
+  {
+    "parameterKey": "IpAddressType",
+    "parameterValue": "ipv4"
+  },
+  {
+    "parameterKey": "Type",
+    "parameterValue": "application"
+  },
+  {
+    "parameterKey": "HTTP2",
+    "parameterValue": "true"
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckPathParameter",
+    "parameterValue": ""
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckPortParameter",
+    "parameterValue": "0"
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckIntervalParameter",
+    "parameterValue": "0"
+  },
+  {
+    "parameterKey": "TargetGroupHealthCheckTimeoutParameter",
+    "parameterValue": "0"
+  }
+]

testdata/ingress_rg_notshared_alb/output/tags/01-ing.json

@@ -0,0 +1,12 @@
+[
+  {
+    "key": "kubernetes:application",
+    "value": ""
+  },{
+    "key": "kubernetes.io/cluster/aws:123:eu-central-1:kube-1",
+    "value": "owned"
+  },{
+    "key": "ingress:certificate-arn/DUMMY",
+    "value": "0001-01-01T00:00:00Z"
+  }
+]

testdata/ingress_rg_notshared_alb/output/tags/02-rg.json

@@ -0,0 +1,15 @@
+[
+  {
+    "key": "kubernetes:application",
+    "value": ""
+  },{
+    "key": "kubernetes.io/cluster/aws:123:eu-central-1:kube-1",
+    "value": "owned"
+  },{
+    "key": "ingress:certificate-arn/DUMMY",
+    "value": "0001-01-01T00:00:00Z"
+  },{
+    "key": "ingress:owner",
+    "value": "/my-route-group"
+  }
+]