Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more goldenfile tests #614

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Add some more goldenfile tests #614

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eccff99
Add more golden file tests - patch 1
MustafaSaber Jun 14, 2023
53d3091
remove `resourcesType` field which is unnecessary
MustafaSaber Jun 15, 2023
473bc79
Fix existing Golden file tests
lucastt Oct 19, 2023
9532601
Fix remaining goldenfile tests
lucastt Oct 19, 2023
9b9f786
Fix ingress sharing parameter in test fixtures
lucastt Oct 19, 2023
4aff9d3
Add ability to check multiple input/output to golden files tests
lucastt Oct 26, 2023
5618b11
Sync annotation and improve naming in golden file tests
lucastt Oct 30, 2023
0e34486
Add issue link to TODO comment in CF mocks
lucastt Oct 31, 2023
90db201
Fix identation
lucastt Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aws/fake/cf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,9 @@ func MockCSOutput(stackId string) *cloudformation.CreateStackOutput {
}

func (m *CFClient) UpdateStack(params *cloudformation.UpdateStackInput) (*cloudformation.UpdateStackOutput, error) {
// TODO: Update stack needs another logic to register state update, so createStack and updateStack don't
// mess with each other states.
// TODO: https://github.com/zalando-incubator/kube-ingress-aws-controller/issues/653
// Update stack needs to use different variable to register change history,
// so createStack and updateStack mocks don't mess with each other states.
lucastt marked this conversation as resolved.
Show resolved Hide resolved

out, ok := m.Outputs.UpdateStack.response.(*cloudformation.UpdateStackOutput)
if !ok {
Expand Down
Loading