Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update hack/schema go mod and add ci check #3372

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jan 6, 2025

Description

The go mod is out of date for hack/schema. This updates the go mod and adds a test to make sure it has to be updated in the future.

The first commit of this PR, did not include the go mod updates to ensure the test will properly fail when the go mod is out of date

Checklist before merging

@AustinAbro321 AustinAbro321 requested review from a team as code owners January 6, 2025 13:43
@AustinAbro321 AustinAbro321 marked this pull request as draft January 6, 2025 13:43
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d1c7ce9
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/677bde741dd8bf0009bba2e8

@AustinAbro321 AustinAbro321 changed the title test to make sure this job fails chore: update hack/schema go mod Jan 6, 2025
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review January 6, 2025 13:45
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@AustinAbro321 AustinAbro321 changed the title chore: update hack/schema go mod chore: update hack/schema go mod and add ci check Jan 6, 2025
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit ba5a459 Jan 6, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-hack-go-mod branch January 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants