fix(suggestion): Trigger suggestion on InsertEnter #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request make that the suggestion get triggered when entering insert mode.
It was not working because both
InsertEnter
andCursorMovedI
would fire at the same time and the timer variable would be messed up in the debounce function like this:InsertEnter
is called,copilot.timer
is set to timer id 1CursorMovedI
is called,copilot.timer
is set to timer id 2timer
is 1,copilot.timer
is 2, early return,copilot.timer
is set tonil
timer
is 2,copilot.timer
isnil
, early returnThis pull requests fixes this, I'm testing this since yesterday and it's working fine, but I don't know the codebase very well so I'm hoping I'm not breaking something.
Also the debounce function doesn't seem to be working (with or without this pull request), it works only as a timeout, does this need to be fixed or is this the intended behavior?