Merge shardtree hotfixes back to main & update shardtree to incrementalmerkletree 0.8.0
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.82 adds support for omitting empty types in pattern matching, which would make these much clearer.
…ackport Backport #119 to shardtree v0.3.x
Release `shardtree v0.3.2`
…merge_shardtree_hotfix
nuttycom
commented
Dec 12, 2024
| pub fn from_parts(root_addr: Address, root: Tree<A, V>) -> Option<Self> { | ||
| /// Returns the newly constructed error, or the address at which the provided tree extends | ||
| /// beyond the position range of the provided root address. | ||
| pub fn from_parts(root_addr: Address, root: Tree<A, V>) -> Result<Self, Address> { |
There was a problem hiding this comment.
I decided to change this to a Result instead of an Option because there are places in the ShardStore API that return Option<LocatedTree>, and I do not want inconsistency to be able to be confused with malformedness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.