Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zcash_keys dependency on zcash_primitives. #1658

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom force-pushed the zcash_transparent_keys branch from b47f4ee to 5b51976 Compare December 15, 2024 19:54
Cargo.toml Outdated Show resolved Hide resolved
zcash_keys/Cargo.toml Outdated Show resolved Hide resolved
zcash_keys/src/address.rs Outdated Show resolved Hide resolved
zcash_keys/src/address.rs Outdated Show resolved Hide resolved
zcash_keys/src/encoding.rs Outdated Show resolved Hide resolved
zcash_keys/src/keys.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the zcash_transparent_keys branch 2 times, most recently from 33897aa to 3fbd114 Compare December 15, 2024 20:06
@nuttycom nuttycom requested a review from str4d December 15, 2024 20:07
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3fbd114

@nuttycom nuttycom force-pushed the zcash_transparent_keys branch from 3fbd114 to 24060bb Compare December 15, 2024 20:19
@nuttycom nuttycom force-pushed the zcash_transparent_keys branch from 24060bb to b1962ac Compare December 15, 2024 20:26
@nuttycom nuttycom merged commit b1962ac into zcash_transparent Dec 15, 2024
30 checks passed
@nuttycom nuttycom deleted the zcash_transparent_keys branch December 15, 2024 21:13
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.96%. Comparing base (e4915f9) to head (b1962ac).

Files with missing lines Patch % Lines
zcash_keys/src/keys.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           zcash_transparent    #1658      +/-   ##
=====================================================
- Coverage              52.98%   52.96%   -0.02%     
=====================================================
  Files                    175      175              
  Lines                  21051    21059       +8     
=====================================================
+ Hits                   11153    11154       +1     
- Misses                  9898     9905       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants