Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_keys: Prepare for no_std usage. #1662

Merged
merged 2 commits into from
Dec 17, 2024
Merged

zcash_keys: Prepare for no_std usage. #1662

merged 2 commits into from
Dec 17, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom force-pushed the zcash_keys-prepare_no_std branch from 97f378e to 1d8ba3d Compare December 16, 2024 22:27
str4d
str4d previously approved these changes Dec 16, 2024
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1d8ba3d

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (c04a71e) to head (b06868e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
zcash_keys/src/address.rs 0.00% 1 Missing ⚠️
zcash_keys/src/keys.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1662   +/-   ##
=======================================
  Coverage   52.94%   52.94%           
=======================================
  Files         175      175           
  Lines       21072    21072           
=======================================
  Hits        11157    11157           
  Misses       9915     9915           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b06868e

@str4d str4d merged commit 0e3c35e into main Dec 17, 2024
32 checks passed
@str4d str4d deleted the zcash_keys-prepare_no_std branch December 17, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants