ZEA-3791: nil pointer issue in zeabur/cli #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no (matched) services in projects, we let users reselect the project.
pan93412
force-pushed
the
pan93412/zea-3791-nil-pointer-issues-on-zeaburcli
branch
from
06aa54d to
0555840
Compare
pan93412
changed the title
MichaelYuhe
approved these changes
Aug 9, 2024
MichaelYuhe
deleted the
pan93412/zea-3791-nil-pointer-issues-on-zeaburcli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Some functions do not handle the
service == nilcase, introducing a nil-pointer panic. This PR fixes it by letting users re-select the project.service == nilis also documented now.Related issues & labels (optional)