Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): Do not use filepath.Separator in the zip file #112

Merged

Conversation

pan93412
Copy link
Member

Description (required)

Reverts #110. Internally we accept only filepath composed with /.

Related issues & labels (optional)

  • Closes ZEA-4046
  • Suggested label: bug

@pan93412 pan93412 self-assigned this Sep 10, 2024
@pan93412 pan93412 force-pushed the pan93412/zea-4046-do-not-use-filepathseperator-in-zip-file branch from 2eaf61c to f2b6105 Compare September 10, 2024 03:49
@pan93412 pan93412 requested a review from yuaanlin September 10, 2024 03:51
@yuaanlin yuaanlin merged commit fd39b61 into main Sep 10, 2024
2 checks passed
@yuaanlin yuaanlin deleted the pan93412/zea-4046-do-not-use-filepathseperator-in-zip-file branch September 10, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants