Skip to content

Commit

Permalink
feat(debugger): use dap-js instead of legacy debug adapters
Browse files Browse the repository at this point in the history
The debug adapters powering [`dap-node`][vscode-node-debug], [`dap-chrome`][vscode-chrome-debug], and [`dap-edge`][vscode-edge-debug2] have all been deprecated and unmaintained for a while in favour of [`vscode-js-debug`][vscode-js-debug].

`dap-mode` has [added support for `vscode-js-debug`][pr], via `dap-js`.

[vscode-node-debug]: https://github.com/microsoft/vscode-node-debug
[vscode-chrome-debug]: https://github.com/Microsoft/vscode-chrome-debug
[vscode-edge-debug2]: https://github.com/microsoft/vscode-edge-debug2
[vscode-js-debug]: emacs-lsp/dap-mode#733
[pr]: emacs-lsp/dap-mode#369
  • Loading branch information
zeorin committed Apr 22, 2024
1 parent 9620bb4 commit 58f5e61
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions modules/tools/debugger/config.el
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
((:lang rust +lsp) :after rustic-mode :require (dap-lldb dap-cpptools))
((:lang javascript +lsp)
:after (js2-mode typescript-mode)
:require (dap-node dap-chrome dap-firefox ,@(if (featurep :system 'windows) '(dap-edge)))))
:require (dap-js dap-firefox)))
"TODO")


Expand All @@ -52,7 +52,7 @@
:defer t
:init (add-to-list '+debugger--realgud-alist
'(realgud:trepan-ni :modes (javascript-mode js2-mode js3-mode)
:package realgud-trepan-ni)))
:package realgud-trepan-ni)))

;; Realgud doesn't generate its autoloads properly so we do it ourselves
(dolist (debugger +debugger--realgud-alist)
Expand Down Expand Up @@ -157,4 +157,4 @@
(use-package! dap-ui
:when (and (modulep! +lsp) (not (modulep! :tools lsp +eglot)))
:hook (dap-mode . dap-ui-mode)
:hook (dap-ui-mode . dap-ui-controls-mode))
:hook (dap-ui-mode . dap-auto-configure-mode))

0 comments on commit 58f5e61

Please sign in to comment.