Avoid to use external git command and include_directory property if possible #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because our use case is bundling LuaJIT and luajit-cmake. Using INCLUDE_DIRECTORIES property on relatively older cmakes causes configuration failues: ``` CMake Error at lib/luajit-cmake/CMakeLists.txt:20 (get_target_property): INTERFACE_LIBRARY targets may only have whitelisted properties. The property "INCLUDE_DIRECTORIES" is not allowed. ``` This could be overkill to set up include directories for such case. Signed-off-by: Hiroshi Hatake <[email protected]>
This is because git command is sometimes absence for container environments. Container environment should be lighter and lighter as much as possible. Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
changed the title
7 tasks
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
avoid-to-use-external-git-command-and-include-directory-property-if-possible
branch
from
66f09f7 to
dd59a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we have been used this CMake module for bundling LuaJIT into fluent-bit.
We have various usages for this module.
This happens that sometimes git command is absent there. So, for generating relver text should be filled out the current timestamp as a dummy relver.
This causes that the
INCLUDE_DIRECTORIESproperty in get_target_property shouldn't be handled correctly. And I found that providing to include this property in get_target_property should solve this compilation issue.The newly introduced
LUAJIT_SETUP_INCLUDE_DIRoption preserves the default behavior. So, it will not be harmful for the most of users.If you have a time, could you take a look these patches?