Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for creation and deletion of activation profiles on z16 #1330

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Nov 5, 2023

For details, see the commit message.
I successfully ran the end2end tests for test_activation_profile.py on A65.

@andy-maier andy-maier self-assigned this Nov 5, 2023
@andy-maier andy-maier added this to the 1.12.0 milestone Nov 5, 2023
@andy-maier andy-maier force-pushed the andy/add-create-delete-activation-profiles branch from a35e1d3 to 5d0f54a Compare November 5, 2023 09:20
@andy-maier andy-maier changed the title Added support for creation and deletion of activation profiles on z16 [WIP] Added support for creation and deletion of activation profiles on z16 Nov 5, 2023
@andy-maier andy-maier force-pushed the andy/add-create-delete-activation-profiles branch from 5d0f54a to 9843065 Compare November 5, 2023 13:28
@coveralls
Copy link
Collaborator

coveralls commented Nov 5, 2023

Coverage Status

coverage: 81.121%. first build
when pulling 9268bdc on andy/add-create-delete-activation-profiles
into d529b71 on master.

@andy-maier andy-maier force-pushed the andy/add-create-delete-activation-profiles branch from 9843065 to 7830c65 Compare November 10, 2023 14:40
@andy-maier andy-maier changed the title [WIP] Added support for creation and deletion of activation profiles on z16 Added support for creation and deletion of activation profiles on z16 Nov 10, 2023
@andy-maier andy-maier linked an issue Nov 10, 2023 that may be closed by this pull request
@andy-maier andy-maier force-pushed the andy/add-create-delete-activation-profiles branch 2 times, most recently from 069f63a to 6d102c0 Compare November 10, 2023 17:43
Details:

* Added a create() method to zhmcclient.ActivationProfileManager.

  At this point, the method deals with the fact that the implementation
  does not return any data, and builds the resource URI from the
  provided name (this is documented differently in the API book).

  The method also deals with the fact that all three create
  operations take 'profile-name' as input for the profile name (this is
  documented as 'name' for image and load profiles).

* Added a delete() method to zhmcclient.ActivationProfile.

* Added end2end testcases for create, delete and update.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier force-pushed the andy/add-create-delete-activation-profiles branch from 6d102c0 to 9268bdc Compare November 10, 2023 17:48
@andy-maier andy-maier merged commit 9b84948 into master Nov 12, 2023
16 checks passed
@andy-maier andy-maier deleted the andy/add-create-delete-activation-profiles branch November 12, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creation and deletion of activation profiles on z16
4 participants