Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support for Partition Links #1685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Oct 5, 2024

WIP TODOs:

  • Add end2end tests for partition: attach / detach / list_attached

@andy-maier andy-maier self-assigned this Oct 5, 2024
@andy-maier andy-maier added this to the 1.19.0 milestone Oct 5, 2024
@andy-maier andy-maier linked an issue Oct 5, 2024 that may be closed by this pull request
@andy-maier andy-maier force-pushed the andy/partition-link branch 2 times, most recently from e3498a8 to 3184b41 Compare October 24, 2024 08:24
@coveralls
Copy link
Collaborator

coveralls commented Oct 24, 2024

Coverage Status

coverage: 81.279% (-1.2%) from 82.504%
when pulling f775287 on andy/partition-link
into 07eb7e7 on master.

@andy-maier andy-maier force-pushed the andy/partition-link branch 3 times, most recently from 2a01040 to 15c7bf0 Compare October 25, 2024 15:17
@andy-maier andy-maier force-pushed the andy/partition-link branch 5 times, most recently from bb1e363 to 4b70c5f Compare January 10, 2025 13:53
Signed-off-by: Andreas Maier <[email protected]>
not enabled for the specified CPC, or if the CPC does not yet support it.

Note that the three partition-link related API features are always all
enabled or all disabled:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully correct. There are code levels for z16 where only SMC-D is enabled, but not HiSo and CTC.

Parameters:

partition_link (:class:`~zhmcclient.PartitionLink`): The partition
link that will be attached to this partition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link that will be attached to this partition.
link that will be detached from this partition.


pl_list = console.partition_links.list(
filter_args=filter_args,
additional_properties=additional_properties)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we always add 'paths' and 'bus-connections' to additional_properties for improved performance as they are used for the filtering below?


Authorization requirements:

* Object-access permission to the CPC that will be associated with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need object access permissions for the CPC on modify for an existing partition link. That's only the case when you create a new partition link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Partition Link resource
3 participants