Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18: Fixed incorrect blanked-out password-like properties #1722

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

andy-maier
Copy link
Member

Rolls back PR #1721 into 1.18.2.

Details:

* The previous fix that blanked out clear-text password-like properties
  had the issue that by mistake it added all possible password-like
  properties with blanked-out values ot the API entry log and HMC request
  log. This change reduces that again to only the properties that exist
  for the resource type.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier changed the title Fixed incorrect blanked-out password-like properties 1.18: Fixed incorrect blanked-out password-like properties Nov 28, 2024
@andy-maier andy-maier self-assigned this Nov 28, 2024
@andy-maier andy-maier added this to the 1.18.2 milestone Nov 28, 2024
@andy-maier andy-maier merged commit 835b4f0 into stable_1.18 Nov 28, 2024
12 checks passed
@andy-maier andy-maier deleted the 1.18/andy/fix-incorrect-blanked-props branch November 28, 2024 19:44
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 82.504% (+0.03%) from 82.472%
when pulling 39849f6 on 1.18/andy/fix-incorrect-blanked-props
into 3cfc688 on stable_1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants