Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTPS to Prometheus #332

Closed
andy-maier opened this issue May 16, 2023 · 2 comments · Fixed by #361
Closed

Support HTTPS to Prometheus #332

andy-maier opened this issue May 16, 2023 · 2 comments · Fixed by #361
Assignees
@andy-maier
Labels
area: code priority resolution: fixed rollback needed type: enhancement New feature or request
Milestone
1.5.0

Comments

@andy-maier
Copy link
Member

Currently, the zhmc exporter uses start_http_server() from the prometheus_client package and thus does not support HTTPS to Prometheus.

This issue is to add support for HTTPS.
@andy-maier andy-maier self-assigned this May 16, 2023
@andy-maier andy-maier added this to the 1.5.0 milestone May 16, 2023
@andy-maier
Copy link
Member Author

It is not clear whether the prometheus_client package supports HTTPS directly between exporter and Prometheus. Opened prometheus/client_python#930 to clarify that.

@Charles1000Chen
Copy link
Contributor

Charles1000Chen commented Jul 31, 2023 •
edited
Loading

@andy-maier Kareza have implemented the mTLS in prometheus client_python: prometheus/client_python#946

@andy-maier andy-maier linked a pull request Jul 31, 2023 that will close this issue
Added support for HTTPS and mutual TLS (mTLS) #361
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-maier andy-maier

Labels
area: code priority resolution: fixed rollback needed type: enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Added support for HTTPS and mutual TLS (mTLS) zhmcclient/zhmc-prometheus-exporter
2 participants
@andy-maier @Charles1000Chen