-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for HTTPS and mutual TLS (mTLS) #361
Conversation
216075b
to
3e175c8
Compare
@andy-maier In our use case, we wanna configure the mTLS related parameters in zhmc exporter's credential yaml. Could you implement loading the mTLS parameters from credential yaml like below:
This way/configuration is our other exporters are using. Thanks. |
@Charles1000Chen I agree this is the better solution. DONE. |
1015aa6
to
ab840e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
b8abe46
to
c77f867
Compare
02f8ee0
to
1f64287
Compare
I updated the PR to use the prometheus-client package from its master branch, now that PR prometheus/client_python#946 has been merged. |
Details: * Added support for communicating with Prometheus using HTTPS by adding a new section 'prometheus' to the HMC credentials file, that can specify server certificate and key files, CA credentials file for validating client certificates (mTLS), and a flag for disabling client vertificate validation. * Since it makes sense to also specify the port for exporting in the new 'prometheus' section, that was also added. The -p command line option overrides the port specified in the HMC credentials file, which defaults to 9291, so this is backwards compatible. * For now, the prometheus-client package is installed from its master branch. Once its new version has been released, it will need to be installed again from Pypi (search for TODO-PYPI in whole repo). Signed-off-by: Andreas Maier <[email protected]>
1f64287
to
4f6d936
Compare
For details, see the commit message, or invoke with
--help-creds
.This PR currently uses the prometheus-client package from its master branch.