Added exception handling for HTTP; Broadened exception handling for HTTPS #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: * Added handling of IOError raised by start_http_server() in the HTTP case (it was already handled in the HTTPS case). * For the HTTPS case, broadened the catching of IOError to now catch Exception, in order to make double sure that we catch everything, in order to investigate the issue with occasional ssl.SSLEOFError exceptions. * Simplified and corrected the error message used for re-raising an exception raised by start_http_server() in the HTTPS case. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/add-http-exception-handling
branch
from
3d31b72 to
48c4787
Compare
andy-maier
changed the title
|
@Charles1000Chen agreed to the change, so I'll merge this PR in order to release a new beta version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Note that this PR does not address the problem reported in issue #397 because I think that error is raised by the HTTPS thread after
start_http_server()has already returned.