Add backing adapter/port as labels to NIC metrics #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/nic-adapter-label
branch
from
face764 to
d89eff1
Compare
andy-maier
force-pushed
the
andy/nic-adapter-label
branch
4 times, most recently
from
fba7098 to
cdcb2a2
Compare
Details: * If metric group 'partition-attached-network-interface' is defined to be fetched, the backing adapters of the respective NICs are determined and stored as dynamic attributes 'adapter_name' and 'port_index' on the zhmcclient.Nic object that is put into the uri2resource dict. * In addition, Jinja2 functions 'adapter_name()' and 'adapter_port()' have been implemented for use by label value definitions of that metric group. These functions look up the zhmcclient.Nic object from the uri2resource dict and get the adapter name and port index from its newly added dynamic attributes. * Finally, two new labels 'adapter' and 'port' have been added to the metric group 'partition-attached-network-interface', that use these two new Jinja2 functions. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/nic-adapter-label
branch
from
cdcb2a2 to
0661f83
Compare
andy-maier
changed the title
anilak11
reviewed
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.