Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LPAR resource metrics for absolute capping #432

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Nov 28, 2023

For details, see the commit message.

@andy-maier andy-maier self-assigned this Nov 28, 2023
@andy-maier andy-maier added this to the 1.5.0 milestone Nov 28, 2023
Details:

* The exporter metrics ..._count_is_capped and ..._processor_count_cap
  have a property expression that inspects the 'type' property of
  the absolute-capping object returned by the HMC. It did that
  incorrectly by comparing the 'type' value with 'processor'.
  However, the correct value is 'processors'.
  This change fixes that.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier force-pushed the andy/fix-abs-capping-type branch from df00982 to 76e6c09 Compare November 28, 2023 03:04
@coveralls
Copy link

Coverage Status

coverage: 36.463%. remained the same
when pulling 76e6c09 on andy/fix-abs-capping-type
into cb6d261 on master.

Copy link

@EdGue42 EdGue42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick.

@andy-maier andy-maier merged commit 7fbf189 into master Nov 28, 2023
16 checks passed
@andy-maier andy-maier deleted the andy/fix-abs-capping-type branch November 28, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants