Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning for resource metrics not returned by HMC #433

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

andy-maier
Copy link
Member

For details, see the commit message.

@andy-maier andy-maier self-assigned this Nov 28, 2023
@andy-maier andy-maier added this to the 1.5.0 milestone Nov 28, 2023
@coveralls
Copy link

coveralls commented Nov 28, 2023

Coverage Status

coverage: 36.304% (-0.2%) from 36.463%
when pulling 233df3d on andy/add-if-cpc-storage
into cb6d261 on master.

@andy-maier andy-maier force-pushed the andy/add-if-cpc-storage branch from 0e687f1 to a7e0da3 Compare November 28, 2023 06:16
Details:

* Resource-based metrics defined in the metric definition file but not
  returned by the HMC as a resource property (e.g. because the HMC is too
  old) now cause a Python warning to be printed.

* Added the respective 'if' conditionals to the default metric definition
  file for such HMC or SE version dependent resource metrics, to not have
  that warning show up when using the default metric definition file.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier merged commit acdd83b into master Nov 28, 2023
16 checks passed
@andy-maier andy-maier deleted the andy/add-if-cpc-storage branch November 28, 2023 08:36
@andy-maier andy-maier restored the andy/add-if-cpc-storage branch November 28, 2023 08:37
@andy-maier andy-maier deleted the andy/add-if-cpc-storage branch November 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants