Fixed missing 'CPC' arg in 'zhmc cpc upgrade' command

Signed-off-by: Andreas Maier <[email protected]>
zhmcclient · Oct 17, 2023 · 0e064c6 · 0e064c6
1 parent 9a15860
commit 0e064c6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -33,6 +33,8 @@ Released: not yet
 
 **Bug fixes:**
 
+* Fixed missing 'CPC' argument in "zhmc cpc upgrade" command. (issue #487).
+
 **Enhancements:**
 
 **Cleanup:**

diff --git a/zhmccli/_cmd_console.py b/zhmccli/_cmd_console.py
@@ -158,10 +158,10 @@ def list_api_features(cmd_ctx, **options):
 @click.option('--accept-firmware', '-a', type=bool, required=False,
               default=True,
               help="Boolean indicating to accept the previous bundle level "
-              "before installing the new level.")
-@click.option('--timeout', '-T', type=int, required=False, default=600,
+              "before installing the new level. Default: true")
+@click.option('--timeout', '-T', type=int, required=False, default=1200,
               help='Timeout (in seconds) when waiting for the HMC upgrade '
-              'to be complete. Default: 600.')
+              'to be complete. Default: 1200.')
 @click.pass_obj
 def console_upgrade(cmd_ctx, **options):
     """

diff --git a/zhmccli/_cmd_cpc.py b/zhmccli/_cmd_cpc.py
@@ -523,16 +523,17 @@ def cpc_list_api_features(cmd_ctx, cpc, **options):
 
 
 @cpc_group.command('upgrade', options_metavar=COMMAND_OPTIONS_METAVAR)
+@click.argument('CPC', type=str, metavar='CPC')
 @click.option('--bundle-level', '-b', type=str, required=True,
               help="Name of the bundle to be installed on the SE "
               "(e.g. 'S71').")
 @click.option('--accept-firmware', '-a', type=bool, required=False,
               default=True,
               help="Boolean indicating to accept the previous bundle level "
-              "before installing the new level.")
-@click.option('--timeout', '-T', type=int, required=False, default=600,
+              "before installing the new level. Default: true")
+@click.option('--timeout', '-T', type=int, required=False, default=1200,
               help='Timeout (in seconds) when waiting for the SE upgrade '
-              'to be complete. Default: 600.')
+              'to be complete. Default: 1200.')
 @click.pass_obj
 def cpc_upgrade(cmd_ctx, cpc, **options):
     """