Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing dev dependencies #687

Closed
wants to merge 1 commit into from
Closed

Conversation

andy-maier
Copy link
Member

No review needed.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier self-assigned this Jan 5, 2025
@andy-maier andy-maier added this to the 1.13.0 milestone Jan 5, 2025
@coveralls
Copy link

Coverage Status

coverage: 36.569%. remained the same
when pulling e627317 on andy/fix-check-reqs
into b70aed0 on master.

@andy-maier
Copy link
Member Author

Closing this PR because the dependency is not a hard dependency:

  • Sphinx uses defusedxml only in a test module.
  • Safety uses ipython only when it happens to be installed.

"make check_reqs" succeeds when defusedxml and ipython are not installed.

@andy-maier andy-maier closed this Jan 5, 2025
@andy-maier andy-maier deleted the andy/fix-check-reqs branch January 5, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants