-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2 small formatting error of default value in options.md #3615
Conversation
@niten94: |
No problem. New pull requests with similar changes could be opened, so I meant to just remind that they may be done already in #3576. I am sorry too that the pull request title is not clear, but I will change it when I get home or tomorrow. |
Hi @niten94: would there have been a way for me to know it was already proposed in another pull request? Regards, Antoine |
These are the only ways that I know to check if a change has already been proposed in another pull request:
Only seeing all pull requests with the proposed change cannot usually be done, so I think it is fine to not spend a lot of time trying to check. |
@niten94 :
And this only finds my PR…
And I couldn't even find my 2nd PR for another documentation bug (PR#3671)… Regards, Antoine |
There is no syntax like Thinking again about my comment,
I checked now how this could be done but an API request that returns the list of files modified has to be made with each pull request too, so this was actually not a good idea.
I think this is the only method usually done even though the results are not accurate. I would usually try searching more than once with combinations of these terms in the case of #3617 as an example: help, options, array, default, value, |
@niten94 : thanks again for taking the time to answer me. And if your feels my contribution in [#3617] is good, don't hesitate to merge it. Actually, if one does:
Regards, Antoine |
There are 2 default values that don't have the proper formatting. This fixes those 2 small formatting error of default value in options.md.
Regards, Antoine