fix: remove incorrect empty notification messages

zzucch · Sep 18, 2024 · fd9b7dd · fd9b7dd
1 parent 9673f36
commit fd9b7dd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/internal/bot/notification.go b/internal/bot/notification.go
@@ -31,7 +31,6 @@ func (b *Bot) handleNotifications() {
 					}
 				}
 
-				log.Debug("lk", "l", notification.Updates)
 				if len(notification.Updates) > 0 {
 					for _, update := range notification.Updates {
 						updateStorage(b.store, notification.ChatID, update)

diff --git a/internal/bot/update.go b/internal/bot/update.go
@@ -11,7 +11,7 @@ func updateStorage(
 	chatID int64,
 	update notification.Update,
 ) {
-	if update.LatestTimestamp != 0 {
+	if update.LatestTimestamp != -1 {
 		if err := store.SetLatestSubtitleTimestamp(
 			chatID,
 			update.TitleID,

diff --git a/internal/notification/notification.go b/internal/notification/notification.go
@@ -57,11 +57,13 @@ func notify(
 				err)
 		}
 
-		message := getUpdateMessage(subscription, update, err)
-		notificationMessageSB.WriteString(message)
+		if update.LatestTimestamp != -1 {
+			message := getUpdateMessage(subscription, update, err)
+			notificationMessageSB.WriteString(message)
+		}
 
 		if err == nil {
-			if update.LatestTimestamp != 0 || update.JapaneseName != "" {
+			if update.LatestTimestamp != -1 || update.JapaneseName != "" {
 				updates = append(updates, update)
 			}
 		}

diff --git a/internal/notification/update.go b/internal/notification/update.go
@@ -22,7 +22,7 @@ func getUpdate(
 	var newFileEntryNames []string
 
 	if subscription.LastModified == lastModified {
-		lastModified = 0
+		lastModified = -1
 	} else {
 		fileEntries, err := client.GetFileEntries(subscription.TitleID)
 		if err != nil {