Don't allocate AttributesCollection in HtmlNode.GetId unless needed

zzzprojects · Jun 29, 2024 · d5c0caf · d5c0caf
1 parent 8efd5da
commit d5c0caf
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/src/HtmlAgilityPack.Shared/HtmlNode.cs b/src/HtmlAgilityPack.Shared/HtmlNode.cs
@@ -254,20 +254,7 @@ public HtmlNode FirstChild
 		/// </summary>
 		public bool HasAttributes
 		{
-			get
-			{
-				if (_attributes == null)
-				{
-					return false;
-				}
-
-				if (_attributes.Count <= 0)
-				{
-					return false;
-				}
-
-				return true;
-			}
+			get { return _attributes != null && _attributes.Count > 0; }
 		}
 
 		/// <summary>
@@ -2324,7 +2311,7 @@ internal void CloseNode(HtmlNode endnode, int level = 0)
 
 		internal string GetId()
 		{
-			HtmlAttribute att = Attributes["id"];
+			HtmlAttribute att = HasAttributes ? Attributes["id"] : null;
 			return att == null ? string.Empty : att.Value;
 		}