Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add is_empty() method to constraint consumers #1646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add is_empty() method to constraint consumers #1646

wants to merge 1 commit into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Jan 8, 2025

Description

Added is_empty() methods to ConstraintConsumer and RecursiveConstraintConsumer structures to check if any constraints have been added.

Motivation

  • Simplifies code debugging
  • Useful for writing tests
  • Helps detect cases where constraints were accidentally not added
  • Follows idiomatic Rust (similar to is_empty() method in standard collections)

Testing

The proposed changes do not break existing functionality and can be easily tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Awaiting requested review from Nashtare Nashtare is a code owner

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga LindaGuiga is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Zero EVM
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crStiv