Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add is_empty() method to constraint consumers #1646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add is_empty() method to constraint consumers #1646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions starky/src/constraint_consumer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ impl<P: PackedField> ConstraintConsumer<P> {
pub fn constraint_last_row(&mut self, constraint: P) {
self.constraint(constraint * self.lagrange_basis_last);
}

/// Returns true if no constraints have been added yet
pub fn is_empty(&self) -> bool {
self.constraint_accs.iter().all(|acc| acc.eq(&P::ZEROS))
}
}

/// Circuit version of [`ConstraintConsumer`].
Expand Down Expand Up @@ -175,4 +180,9 @@ impl<F: RichField + Extendable<D>, const D: usize> RecursiveConstraintConsumer<F
let filtered_constraint = builder.mul_extension(constraint, self.lagrange_basis_last);
self.constraint(builder, filtered_constraint);
}

/// Returns true if no constraints have been added yet
pub fn is_empty(&self, builder: &mut CircuitBuilder<F, D>) -> bool {
self.constraint_accs.iter().all(|&acc| acc == self.constraint_accs[0])
}
}