Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: Do not perform unnecessary processing #24818

Conversation

muramura
Copy link
Contributor

If there is no instance, I think it is unnecessary to execute the following process.

@rmackay9
Copy link
Contributor

I'm not sure this is an improvement though..

@muramura muramura force-pushed the AP_Do_not_perform_unnecessary_processing branch from 82c9702 to f6f10cd Compare August 31, 2023 14:39
@muramura
Copy link
Contributor Author

@rmackay9 san. I have made changes.

@peterbarker peterbarker force-pushed the AP_Do_not_perform_unnecessary_processing branch 2 times, most recently from 50dafa3 to 64f159a Compare April 11, 2024 02:31
@peterbarker peterbarker force-pushed the AP_Do_not_perform_unnecessary_processing branch from 64f159a to 5df7d06 Compare April 11, 2024 02:32
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more in-line with our early-return pattern.

Not calling the superclass method is also a good thing. Some contorted thinking could show it as avoiding bugs in the future.

@peterbarker peterbarker merged commit a9d0bf8 into ArduPilot:master Apr 11, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants